IronCoreLabs / ironhide

Tool to easily encrypt and decrypt files to users and groups. Similar to GPG, but usable at scale.
GNU Affero General Public License v3.0
44 stars 6 forks source link

Output not visible in GitHub Actions #88

Open giarc3 opened 1 year ago

giarc3 commented 1 year ago

File decryption output is not visible when using ironhide in GitHub Actions. We use this function for our output (or println_paint):

pub fn print_paint(paint: yansi::Paint<String>) {
    // only print to stdout if we're not being piped somewhere
    if atty::is(atty::Stream::Stdout) {
        print!("{}", paint);
    }
}

I assume the condition is failing in this environment, in which case we print out nothing. The atty also seems abandoned.

skeet70 commented 12 months ago

We worked around this in IronCoreLabs/ironhide-actions like this and like this. We still don't have a solution for Windows, and either way the issue still stands.

We'd need a design of how we want to fix this. It's common to use isatty to toggle features like sending colors or not, but it isn't common to use it to decision sending output at all.