search

IronCoreLabs / ironoxide

Rust SDK for IronCore Privacy Platform
https://docs.rs/ironoxide
GNU Affero General Public License v3.0
10 stars 3 forks source link

[#131] Add feature flags to configure TLS impl used #132

Closed clintfred closed 4 years ago

clintfred commented 4 years ago

see #131

Adds new feature flags to ironoxide for choosing a TLS dependency.

From Cargo.toml

# NOTE: ironoxide requires a TLS implementation. Choose one of the following

# enable to use statically compiled openssl on supported OpenSSL platforms; use with 'default-features = false'
tls-vendored-openssl = ["reqwest/native-tls-vendored"]

# enable to use rustls-tls; use with 'default-features = false'
tls-rustls = ["reqwest/rustls-tls"]

# dynamically use the target platform's native TLS
tls-default = ["reqwest/default-tls"]

This is not currently exercised in CI. It should be added with #130

coltfred commented 4 years ago

Besides the tests we should have, I'm ok with this. Maybe add words to the github actions migration ticket so we add those tests when we move?