IronCoreLabs / recrypt-rs

A set of cryptographic primitives for building a multi-hop Proxy Re-encryption scheme, known as Transform Encryption.
https://crates.io/crates/recrypt
GNU Affero General Public License v3.0
144 stars 23 forks source link

GitHub CI #113

Closed cjyar closed 4 years ago

cjyar commented 4 years ago

Some notes:

cjyar commented 4 years ago

Problem:

Fiddle:recrypt-rs chris$ critcmp one two -t 5
group                        one                                    two
-----                        ---                                    ---
256-bit decrypt (level 0)    1.00      7.1±0.09ms        ? B/sec    1.07      7.6±0.61ms        ? B/sec
Fiddle:recrypt-rs chris$ echo $?
0
Fiddle:recrypt-rs chris$ critcmp one two -t 8
no benchmark comparisons to show
Fiddle:recrypt-rs chris$ echo $?
1

...in other words, critcmp will fail the build if the two benchmark runs are identical to within the configured threshold. I think this is the opposite of what we want, but also the threshold of 2% is way too low.

github-actions[bot] commented 4 years ago

Benchmark results comparing with base:

github-actions[bot] commented 4 years ago

Benchmark results comparing with base:

group                               base                                   current
-----                               ----                                   -------
256-bit compute public key          1.06  1308.7±38.01µs        ? B/sec    1.00  1235.9±18.86µs        ? B/sec
256-bit decrypt (level 0)           1.05     11.2±0.20ms        ? B/sec    1.00     10.7±0.13ms        ? B/sec
256-bit decrypt (level 1)           1.06     41.6±0.72ms        ? B/sec    1.00     39.4±0.39ms        ? B/sec
256-bit decrypt (level 2)           1.05     70.9±0.96ms        ? B/sec    1.00     67.3±0.83ms        ? B/sec
256-bit derive symmetric key        1.11      3.7±0.43µs        ? B/sec    1.00      3.3±0.23µs        ? B/sec
256-bit encrypt (level 0)           1.06     12.6±0.39ms        ? B/sec    1.00     11.8±0.14ms        ? B/sec
256-bit generate ed25519 keypair    1.09     28.4±0.57µs        ? B/sec    1.00     26.1±0.46µs        ? B/sec
256-bit generate key pair           1.06  1316.7±29.43µs        ? B/sec    1.00  1239.0±23.70µs        ? B/sec
256-bit generate plaintext          1.08      5.5±0.12ms        ? B/sec    1.00      5.0±0.11ms        ? B/sec
256-bit generate transform key      1.06     27.3±0.62ms        ? B/sec    1.00     25.8±0.38ms        ? B/sec
256-bit transform (level 1)         1.06     33.1±0.69ms        ? B/sec    1.00     31.1±0.46ms        ? B/sec
256-bit transform (level 2)         1.09     77.4±1.66ms        ? B/sec    1.00     71.4±0.65ms        ? B/sec
github-actions[bot] commented 4 years ago

Benchmark results comparing with base:

group                             base                                   current
-----                             ----                                   -------
256-bit decrypt (level 0)         1.12      9.7±0.29ms        ? B/sec    1.00      8.7±0.27ms        ? B/sec
256-bit decrypt (level 1)         1.04     33.8±1.58ms        ? B/sec    1.00     32.5±1.42ms        ? B/sec
256-bit decrypt (level 2)         1.09     59.8±3.75ms        ? B/sec    1.00     54.7±1.03ms        ? B/sec
256-bit derive symmetric key      1.32      3.7±3.51µs        ? B/sec    1.00      2.8±0.63µs        ? B/sec
256-bit encrypt (level 0)         1.08     10.7±0.33ms        ? B/sec    1.00      9.9±0.40ms        ? B/sec
256-bit generate key pair         1.07  1077.7±65.82µs        ? B/sec    1.00  1010.2±31.42µs        ? B/sec
256-bit generate plaintext        1.03      4.2±0.17ms        ? B/sec    1.00      4.1±0.15ms        ? B/sec
256-bit generate transform key    1.00     21.2±0.88ms        ? B/sec    1.02     21.7±1.21ms        ? B/sec
256-bit transform (level 1)       1.11     28.1±0.78ms        ? B/sec    1.00     25.2±0.69ms        ? B/sec
256-bit transform (level 2)       1.05     61.6±3.61ms        ? B/sec    1.00     58.5±1.92ms        ? B/sec