Remove dependency on arrayvec

IronCoreLabs / recrypt-rs

A set of cryptographic primitives for building a multi-hop Proxy Re-encryption scheme, known as Transform Encryption.

https://crates.io/crates/recrypt

GNU Affero General Public License v3.0

144 stars 23 forks source link

Remove dependency on arrayvec #152

Closed giarc3 closed 3 years ago

giarc3 commented 3 years ago

Would need to bump MSRV to 1.48 because of this addition to Rust. We could possibly make do with an implementation available start in 1.43, but it doesn't seem as clean.

Open to opinions on if the bump to 1.48 is acceptable, or if we should make an attempt at the 1.43 version instead.

CI changes:

More resilient way of installing rustfmt, as it's not always available on nightly.
Switch to using rust_cache, which we've been moving towards already as we've been adding sccache. This is just an intermediate step towards that with less noise and some bugfixes built in

clintfred commented 3 years ago

I think the PR description should mention the build changes. I think you are just using rust_cache?

giarc3 commented 3 years ago

I think the PR description should mention the build changes. I think you are just using rust_cache?

I added a brief description of the CI changes. They were fairly minor.

skeet70 commented 3 years ago

I think if we're bumping MSRV we should at least minor bump. Too easy for a patch version to break builds. We might want to make public policy about that.

giarc3 commented 3 years ago

I think if we're bumping MSRV we should at least minor bump. Too easy for a patch version to break builds. We might want to make public policy about that.

You're 100% right. We do need a policy on that because we've been burned by it with our dependencies multiple times