[Bug]: HTTP Call: missing URL validation

Ironclad / rivet

The open-source visual AI programming environment and TypeScript library

https://rivet.ironcladapp.com

MIT License

2.71k stars 237 forks source link

[Bug]: HTTP Call: missing URL validation #289

Closed mindplay-dk closed 8 months ago

mindplay-dk commented 9 months ago

What happened?

If you put a relative URL such as /something in the URL input of the HTTP Call block, apparently it makes a request to some default host-name.

What was the expected functionality?

Invalid URL should yield an error.

Describe your environment

Win 11 (Browser executor)

Relevant log output

No response

Relevant screenshots

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

codemile commented 9 months ago

I see this as being related to #290

mindplay-dk commented 9 months ago

Yes, although that issue doesn't specifically address any missing validations - stuff like this isn't likely going to automatically emerge just by introducing a validation library. Some thinking and planning for each input will be required. 🙂

abrenneke commented 8 months ago

Fixed in 4f4d943188cf10306fafd09882b8f202a499276e