fix: Mitigating undefined bug in `alreadyOpenedProject.fsPath`

Ironclad / rivet

The open-source visual AI programming environment and TypeScript library

https://rivet.ironcladapp.com

MIT License

2.71k stars 237 forks source link

fix: Mitigating undefined bug in `alreadyOpenedProject.fsPath` #310

Closed AryamanAgrawalIronclad closed 8 months ago

AryamanAgrawalIronclad commented 8 months ago

When using File > Open Project we were encountering an undefined value when trying to parse alreadyOpenedProject.fsPath
We can mitigate this by placing another check to make sure that the field fsPath exists in alreadyOpenedProject

Error:

codemile commented 8 months ago

This error is fixed as part of this PR, but silencing undefined error won't fix the underlying issue. The real problem is related to closing/reopening projects that are kept in localStorage.

https://github.com/Ironclad/rivet/pull/293

Anyway, I'm happy to merge this PR and move forward with finishing my PR. It still needs some improvements, but we might as well get rid of this undefined error.

codemile commented 8 months ago

I have resolved the feedback on my PR #293 and if approved can be merged. Thanks for the help @AryamanAgrawalIronclad but this can be closed.

abrenneke commented 8 months ago

Thanks @AryamanAgrawalIronclad I've merged the other PR which fixes the root problem!

AryamanAgrawalIronclad commented 8 months ago

Sounds good! Thanks for finding the right solve!