Open powerhungry4 opened 2 months ago
LudovicT
commented
2 months ago You cannot create a new branch on this repository as you don't have permission to contribute directly. If you want to open a PR you need to fork the repository, create your branch there, and open the PR from your own repository to this one.
powerhungry4
commented
2 months ago Thanks @LudovicT for explaining what I was doing wrong, I did as you said and made a PR here: https://github.com/IroncladGames/tools/pull/17
EDIT: Keeping everything is this one issue now. Here are the links to the other two issues I made for reference: https://github.com/IroncladGames/tools/issues/15 https://github.com/IroncladGames/tools/issues/16
I saw some schema related issues when I started modding so I went ahead and took a look at some of them. Will come out with more of these as I deal with them. Would love to submit to a branch and make a PR but I get the following message (I did lose access to my account recently and have to start over, not sure if that's related):
` ...\tools>git branch
...\tools>git checkout -b "schema/fixed_buff-schema.json" Switched to a new branch 'schema/fixed_buff-schema.json'
...\tools>git add json_schemas\buff-schema.json ...\tools>git commit -m "Fixed all issues with buff-schema.json" [schema/fixed_buff-schema.json 036b8f2] Fixed all issues with buff-schema.json 1 file changed, 19 insertions(+), 623 deletions(-)
...\tools>git push origin schema/fixed_buff-schema.json Logon failed, use ctrl+c to cancel basic credential prompt. remote: Permission to IroncladGames/tools.git denied to powerhungry4. fatal: unable to access 'https://github.com/IroncladGames/tools.git/': The requested URL returned error: 403 `
Anyway, the following updated tools/json_schemas/buff-schema.json file fixes all schema issues present in *.buff files. If some off the additions are not supposed to be present, than it means there's a bug in the current steam version of the game. Cheers buff-schema.json