ta-data-bcn
commented
1 year ago Heeelloo Tom 🚀
Good job on the third project, see below for comments :)
Organization of your files 📚
- Your .gitignore works perfectly! You could also add the .DS_Store
- I would add a src folder for the .py files (when you have them) and a data folder for the .csv
README.md ✍🏽
- Your README is improvable, but I guess it was due to lack of time. When you have time try to add images of maps to show your results. You can also add headers and subheaders.
- Try to make it more attractive. You can also add the tools and libraries you used.
The code 👨🏽💻
- Good job doing Mongo queries & Foursquare API's.
- Great job doing a function to get all nearby venues at once by passing a dictionary of category codes :)
- Good job measuring the distances from every company to the different venues and choosing the one with the smallest distance. Also good idea to give different weights to different venues. It's a nice way of basing you decision entirely on data.
- In general your code looks good. For the next project, and for this one, when you have time to make some changes, please try to put code into functions and into .py files. It makes it more organized and easier to read.
Viz 🎨
- You don't have any 😔 try to make some when you have time. You analysis is really good and you already have your final location, you just need to make your results visual.
In general, your project is okay. The analysis and the code looks good, you'd just need to update the README and create a couple of maps. I know it was due to lack of time, so when you have a little bit more time (it can be after the bootcamp), try to work a little bit more on it.
Congrats on the good work and good luck on the next one :)
https://github.com/TomBanner/4square