ta-data-bcn
commented
1 year ago Heeelloo Graham 🚀
Good job on the third project, see below for comments :)
Organization of your files 📚
- Your .gitignore works perfectly! You could also add the pycache
- I would add a src folder for the .py files and an images folder.
README.md ✍🏽
- Your README is great. You walk the reader through the process you went through and show the results 🔝
The code 👨🏽💻
- Great job not just looking at the companies database to argue your decision, but looking for more data on tax rates and F1 circuits.
- Good job doing Mongo queries & Foursquare API's.
- In general your code looks good 🙌🏾 and you did put everything into functions...I remember you couldn't import dotenv and that's why it appears you have errors...just remember to do another commit with the final version so everything is up to date :)
Viz 🎨
- The maps look good, great job plotting markers for venues around Singapore and that way finding the location that better satisfied the company's needs.
In general, your project looks good Graham, just remember to do another commit with the new version.
Congraats and enjoooy the free weekend :)
https://github.com/Detest9067/Project-3-Maps