ta-data-bcn
commented
1 year ago Heeelloo Tom 🚀
Good job on the fourth project. Apart from what Fer told you in the presentation, here is a little bit more of feedback 👇🏾
Organization of your files 📚
- Your .gitignore works perfectly! You could also add the .DS_Store and the .ipynb_checkpoints so they don't upload to the repo.
- I would also add a data folder for the .csv's
README.md ✍🏽
- Your README loooks fine. You went though all the process, divided everything with subtitles and explained what the data and what the project was about 🔝
- Also great job adding screenshots of your Tableau graphs.
The code (Python & SQL) 👨🏽💻
- In this case it isn't that important, but remember when you use .env to hide a password not to leave it printed in the jupyter notebook 👀 even if you ignore the .env, if you leave the password printed, everyone is going to see it when they see your code.
- Good job using the News API and applying sentiment analysis to the result, you can add more countries in the future when you can request more calls. And remember to take out your API key.
- I looove the heatmap df 👏🏾 really good job. You can take out the year as Fer told you, but it's great that you made it very visual.
- Great job doing SQL queries.
- Nice sentiment analysis and really good job doing a linear regression before we saw it in class :)
- In general your code looks good, but when you have time to make some changes, please try to put code into functions and into .py files. It makes it more organized and easier to read. You already have some good functions, you'd just have to put them in .py files.
Viz (Tableau) 🎨
- I like your graphs. The scatterplots are nice.
- Try to fill the countries in the map that are empty, most of the times it's because the name in your data and the name Tableau uses is not exactly the same, but it is suuuuper easy to change.
- For the barplot, you could separate them into different graphs, so each can keep its scale. The same way you did with the scatterplots.
In general, your project looks goood Tom.
Congrats on the good work and good luck on the final one, i am sure your going to do a great job 🙌🏾
https://github.com/TomBanner/Happiness/tree/main