ta-data-bcn
commented
2 years ago Three projects down! Two to go. As always, good job, and here are a few comments for that extra 110%.
Analysis + Visuals
- Your text was concise and got the job done; well done.
- Great map, but I would have colored the offices you are choosing differently or somehow made them stand out.
- You didn't name the city you chose at the end of your readme!
Code
- Remember to label your CSV files and images so that others can understand them at a glance.
- Tons of functions! Awesome. It does look like you could have made more functions, looking at a couple repetitive blocks in your code.
- You might want to split long function files into more specific files like vis, scrape, etc.
Organization
- Good folder organization, but remember to keep your main notebook in the root folder.
- checkpoints, nooo! 😱 gitignore!
https://github.com/GuilleNes/project-III-geospatial-data