ta-data-bcn
commented
2 years ago 😂 great title! Three projects down, two to go. As always, good job and here are a few comments for that extra 110%.
Analysis + Visuals
- You used the data well to reason through your decisions.
- Your maps and text were also very clear, good report!
- Sam and I love looking at your work. We can tell you really enjoy this and you're really good at it. Happy for you, man!
Code
- Great use of functions! I'm confident you'll do well in your next job, whatever you find.
- If your function file is too long, consider compartmentalizing it into several files with unique names. Ie viz, scrape, etc.
Organization
- Great folder organization, but I would put my notebooks in the root folder.
- well-defined commit comments 🎩 the mark of a true gentleman. I think you can add a tiny bit more, for example, your functions file shows 'added a cool circle' and should also say that and ' + function file update.'
https://github.com/csuoc/third_project_geospatial_data