Em :) - EDA & Data wrangling

[emmacunill]

https://github.com/emmacunill/project_em.git

[sh-ih]

Emma,

Congrats on your first project! 🏆

Some comments:

• Repo Structure You have very good file structure with clearly named files. I really liked how you used your images folder for all your graphs, It is a great way to avoid having to remake graphs because you didn’t save them as images, The only suggestion would be to add the sharks.zip file to your .gitignore and only keep the cleaned_attacks.csv on your data folder.

• Data Cleaning The addition of comments to your code is a great habit to have, because anyone can understand what you are doing and your interpretations. Keep doing it!

Great work on the docstrings of your functions. To make them even better, I would recommend you avoid writing in first person (“first I transform manually the nan”) to a more neutral tone:

“Substitute NaN values for: ‘Unknown’ 15 if value is ‘‘teen” or a variation of that string 50 if value is “adult” or a variation of that string 2 if value is ‘18 months’

• Data visualization Lovely storytelling on your visualization notebook! The addition of your comments makes it a lot more interesting that only seeing graphs.

Your labels and axis are clearly identified. I would only suggest you to add titles, so each individual graph can be completely understood on its own. For example, for the attacks by gender, the title could be ‘Shark attacks by gender (1957 to 2018)’.

• README Not a lot of comments here. It is a very good README. Most of the time, when we get to the readme we are tired and out of time, but it is a really important way to show your work at a glance and catch people’s attention. You did great.

• Bonus I liked your presentation. One suggestion would be to try to use a little less text on each slide. Each sentence is not very long, keep doing that, but maybe try to use less text and give more space to your graphs.

Next project won’t have as much cleaning work so you’ll be able to allocate more time to encapsulating your functions. It is a great way to improve your projects.

All in all, great job on this first project. Keep it up for the next one! 💫