sh-ih
commented
8 months ago You did great on this project!
- Repository Your repository has a very organized structure and your files have clear names. It is also very good that each folder has only the expected files (only .py files on src and only .ipynb files on notebooks). It is always nice to know you can go to the notebooks file and actually find only notebooks and not other files.
I would suggest you to add the draft notebook to the .gitignore, because that’s really not adding to your repository, it is more of your own workflow.
- Acquisition and enrichment of database It was an excellent decision to go back in time to enrich your database with songs from before 1990.
When working with APIs that have restricted access, it is always advisable to protect your access keys. It is good that you protected your client_secret. I just want to show this tutorial to hide both your client_id and client_secret)using .gitignore https://medium.com/black-tech-diva/hide-your-api-keys-7635e181a06c
-
Reporting You have your analysis and conclusions mainly on your README, but it is important that you include that too in the notebook that will work as your final report, in this case it could be the visualization.ipynb or you could even create a notebook just for the final report, where you can develop your storytelling. You have the opportunity to write more in depth analysis and conclusions there and just keep the most attractive points in the README.
-
README Five stars on your title: “What are hits are made of?” An excellent way to capture the attention of your reader.
I would only recommend you to add your interpretation of the graphs you are showing. Is danceability and popularity relationship different throughout the decades? What about the other two features?
When you filtered your results to only the most popular songs, what parameter did you use to select the most popular songs? Top 100 songs? Top 25%? It would be good to explain it here.
And also add your conclusions to the corresponding section.
- Bonus: modularization/encapsulation Great job on the encapsulation. This makes a lot easier to manage and scale a project.
https://github.com/luciaaguzzoni/project-II