Open UriCVV opened 11 months ago
You did great on this project! Some comments:
Repository You have a clear folder structure and a well organized repository. A way to improve it would be to use more descriptive names on your graph files, instead of figure1.png you could use “top_10_countries_smoking_prevalence.png” so the readers can have an idea of what they’ll find inside each file.
Acquisition and enrichment of database Good job combining multiple sources, including the currency API and web scraping, to create a more robust dataset. And Selenium is an amazing tool to scrape. It is a very good idea to start using it since now.
Reporting Your analysis and conclusions are not clearly shown on a notebook nor in your README.
It is important that you include text with your interpretations of the results you got and what the graphs are showing, as well as telling the reader your conclusions.
You can do it either in a notebook that will work as your final report or in one of the other notebooks, but you need a place where you can develop your storytelling. You have the opportunity to write more in depth analysis and conclusions there and just keep the most attractive points in the README. Instead of saying “this project provides valuable insights”, you need to clearly state the insights.
On your Tobacco Use Prevalence vs. GDP (2008 and 2018)' you have a couple of outliers with high GDP and low prevalence. It would be a good idea to identify them and remove them to check if the graph shows a more clear relationship between the variables if the x axis range is smaller.
A way to improve it would be to list your analysis and results, alongside the corresponding visualizations, right here on the README.
Instead of wriitng “The analysis reveals insights into the changes in cigarette smoking prevalence over the years, correlations between smoking prevalence and GDP”, show the insights, the correlations and other relevant visualizations. If you think you have too many, pick the most attractive ones to capture your reader's attention.
project-II-pipelines this is may api key so you can run the code if you want: cur_live_AmzxX9c02B3yUdYzXJsBJgAQz5tBiGjcEQRIfTSm
PD: don't worry, limit is hight and cannot be surpassed;)