search

Ironhack-data-bcn-oct-2023 / project-II-pipelines

0 stars 2 forks source link

[Pere] Project Cocktails #14

Open perikoloso opened 11 months ago

perikoloso commented 11 months ago

https://github.com/perikoloso/project-II-pipelines

sh-ih commented 11 months ago

You did great on this project! Some comments:

A possible improvement is to use more descriptive names on your image folder, instead of chart1.png, you can use the title of the graph “cocktails_by_category.png”, so anyone can know what each image contains without having to open each and every one.

Also, it helps to be consistent on the order of your information. If your hypothesis where: 1)c categories, 2) calories 3) distribution of calories, the order of your conclusions should be the same, but you put calories first, categories next and then a conclusion that didn’t relate to your hypothesis. What happened to the distribution of calories?

Also, the way the first conclusion is redacted is confusing. Did you wanted to say somethin like: “Calories from the analyzed cocktails are concentrated around a median of XXX calories (give us the numbers here!), but some can have a calorie value of up to XXX calories, similar to a piece of grilled chicken.”

image

perikoloso commented 11 months ago

Thanks for your feedback!!!

El El mié, 8 nov 2023 a las 6:10, Sandra Hernández @.***> escribió:

You did great on this project! Some comments:

  • Repository You have a good folder structure and your files are organized in a clear manner.

A possible improvement is to use more descriptive names on your image folder, instead of chart1.png, you can use the title of the graph “cocktails_by_category.png”, so anyone can know what each image contains without having to open each and every one.

-

Acquisition and enrichment of database It was a good decision to obtain your data from scraping a top-tier website and the addition of the garnish caloric data makes this an interesting and different project.

Reporting Your analysis and conclusions are clearly stated on your PowerPoint presentation but to see them, the reader needs to download the file. It would be better that you put more of that analysis in your README and that you also include it in a notebook: either the one where you did your analysis and visualizations or even create a complete notebook that shows all your storytelling.

README You have a clear and organized README. A way to improve it would be to show the corresponding visualizations alongside your analysis and conclusions, right here on the README.

Also, it helps to be consistent on the order of your information. If your hypothesis where: 1)c categories, 2) calories 3) distribution of calories, the order of your conclusions should be the same, but you put calories first, categories next and then a conclusion that didn’t relate to your hypothesis. What happened to the distribution of calories?

Also, the way the first conclusion is redacted is confusing. Did you wanted to say somethin like: “Calories from the analyzed cocktails are concentrated around a median of XXX calories (give us the numbers here!), but some can have a calorie value of up to XXX calories, similar to a piece of grilled chicken.”

  • Bonus: modularization/encapsulation Great job creating your .py files and calling those functions on your main file.

[image: image] https://user-images.githubusercontent.com/130106242/281267393-01b6e360-a606-440f-a384-f9feece9a07a.png

— Reply to this email directly, view it on GitHub https://github.com/Ironhack-data-bcn-oct-2023/project-II-pipelines/issues/14#issuecomment-1801095398, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCLQ4656PGF7YWPH6MKULITYDMH3PAVCNFSM6AAAAAA6XH7I3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBRGA4TKMZZHA . You are receiving this because you authored the thread.Message ID: <Ironhack-data-bcn-oct-2023/project-II-pipelines/issues/14/1801095398@ github.com>