Open patriciazapatab opened 1 year ago
You did great on this project! Some comments:
Repository Your repository is organized and has a good folder structure. I would only add the .gitignore so you can avoid the .ipynb_checkpoints from appearing on your repository.
Reporting Your analysis and conclusions are concentrated on your README file. I would suggest you try to add that information also on a notebook that contains both code and the text with your analysis and can work as a final report notebook, as point F on the project explained it: “The finished report must be a very pretty jupyter notebook, with text, clean code, meaningful outputs, plots and charts.”
README You have a very organized and informative README. It takes us through your process and shows your analysis and conclusions. Adding the visualizations alongside the text is a great way to make an interesting presentation.
Bonus: modularization/encapsulation Great job on the encapsulation part! It makes projects easier to maintain and expand, because you don’t have to go hunting for the place where you ran an action. You just go to the corresponding .py file and update or modify what you need.
https://github.com/patriciazapatab/project-2
(Missing READ.ME file, will update it in the next commit)