Ricardo - Project II

[Ricardo-Beato]

https://github.com/Ricardo-Beato/Project-2/tree/main

[bripollc]

Ricardo,

First of all, second project done!!! You've put a lot of effort into it and it shows with this great work!!!!!!! Congratulations:) I leave you some feedback:

🧹 Repository organization

• The repository is very well organized, clean and easy to navigate! You have created the necessary folders and the file names are clear, which I really appreciate because it helps me to understand what is what:)
• In the repo I only lack to see a file called main.py or ipynb that will be the main execution file, and that will go outside all the folders.

👨🏽‍💻 Code

• Great! All your code is in encapsulated functions:) Yuhuuu! Also very nice the use of doctrings to document what happens in each one! It will be super useful in the future for you and others.
• The only thing is that I would separate the code in different .py files (extraction, transforming, visualization, etc). This way, in the future it will be easier to modify your code or to know which parts fail.
• I also miss a main execution file (py or ipynb) to import the functions from the other files and run all the code from there:)
• Finally, good job, you managed to scrape quite a lot of information and you knew how to put it together to enrich your original csv, which is what the project required. Well executed!

🎨 Visualizations

• The visualizations are fine. Although I think that, with the information you had, you could have gone a bit deeper and made more representative and detailed plots. Also, in those that you make correlations there is no correlation at all...?(xd) At the end, to don't have a conclusion is also a conclusion, but maybe it would be more convenient to use another type of plot?

✍🏽 Readme

• Top! There are titles, subtitles... And in general everything is very well explained, structured and referenced! It is fluid to read and you can understand what you have used, your approaches, your process to reach your results and conclusions :)
• Maybe I'm missing some bulletpoint to make it a bit easier to read when you list the libraries and key features/methods you use.
• I would have also included your graphics to the readme! It's what finally explains better your hypothesis.

In general I think it's a good project with some little things to polish. Also, the topic is super original and interesting!!!!✨ There are hours of work behind and it shows when I see the project. You're working hard and your motivation for the course is evident! CONTINUA ASSIM! 🚀