Leon

[leonplaza]

https://github.com/leonplaza/project-2.git

[sh-ih]

Good job! Some comments:

• Repository Your repository is lacking of several important folders and files. A suggested folder structure is: -- data: to store the csv with your cleaned dataset -- images: to store your visualizations -- notebooks: to concentrate all the notebooks you created: scrapping, cleaning, visualization, the notebook with your final report -- src: to concentrate your .py files with the functions you made for cleaning, visualization, scrapping

• Notebooks To keep a project organized, it is always better to concentrate the same type of activities in one notebook, for example, one notebook for the scrapping part (I didn’t see this code in your repository, it is a good idea to include it), another notebook for the cleaning and enrichment of your dataset and so on.

• Reporting Your analysis and conclusions are concentrated on your README file. I would suggest you try to add that information also on a notebook, so you have both code and your texts together, instead of only showing the visualizations in your notebook, without your interpretations.

• README You have a well organized README, including your question and analysis. It is still missing the visualizations and tables, so keep working on it so it is complete. This is where it will be useful that you have an images folder, because you can get the link to each image from there and use markdown to show the images alongside your text.

• Bonus: modularization/encapsulation I see you did create functions to make different cleaning actions, as well as visualizations. The next step would be to concentrate those functions in their corresponding .py files and then import those files into your notebooks.