Patricia Sáez-Torres - Project II-REO

[psaeztorres]

https://github.com/psaeztorres/PROJECT-II.git

[sh-ih]

You did great on this project! Some comments:

• Repository Your repository has a good structure, although you have two folders for data (data and clean databases). It is better to concentrate all of the same type of info inside one single folder. You could have a data folder and then, inside that one, a raw folder (for the original databases) and a clean folder (for your cleaned databases).

You also need a notebooks folder, to concentrate all of your jupyter notebooks and use clearer names for them (something like webscrapping.ipynb or enrichment-of-databases.ipynb). On the top level of your repo ideally you should only have your readme, main.py and all the folders.

What were the errors that prevented you from moving the files? Let me know if you want to discuss them.

Most of your graphs inside the images folder have a clear file name. That’s always a good way to go because it is easier for everyone to find a specific graph.

• Acquisition and enrichment of database I followed your comment and checked your PROJECT-II and answers.info notebooks. You did a really good job merging both datasets.

• Reporting You have some analysis and conclusions on your README, but it is important that you include that too in your notebooks, alongside your code, or even create a notebook just for the final report, where you can develop your storytelling. You have the opportunity to write more in depth analysis and conclusions there and just keep the most attractive points in the README.

On your answers_info, you improve your visualizations, since all your metals end in Oxide, you could eliminate that word on every name and then make a note that all metals are oxides.

You have some comments on your code, but you should add some paragraphs with your conclusions after working on the data.

Your canva link is not open to the public, so I wasn’t able to check your presentation. Remember to check the option “Anyone with the link” and select “Can View”.

• README Your README has a good structure. I only recommend that you pay closer attention to punctuation and the use of uppercase/lowecase letters when appropriate, because you have several sentences that start with lowercase and some sentences that end with a colon.

Your conclusions section would be clearer if you separate each point, instead of having a big block of text.

Another way to make your README more attractive is to include your visualizations right along with your conclusions, that way the reader can see both at the same time. Here is a tutorial to do that: https://www.digitalocean.com/community/tutorials/markdown-markdown-images

Your initial image is showing as broken because you used the link of the Google search result, instead of the link to the image: https://www.thoughtco.com/thmb/l61nJt1iaT0dxpcYcnTNno_12wE=/1500x0/filters:no_upscale():max_bytes(150000):strip_icc()/rare-earth-metals-conceptual-image-184893255-588524525f9b58bdb355bc2e.jpg You can get the direct link to an image by right clicking and then selecting “Open image in a new window” and then using the URL of that new window.

• Bonus: modularization/encapsulation I see that you created all your .py files with your functions. The next step would be to import them to your notebooks. Then you can modify your notebooks to call those modules to use the functions.