ta-data-bcn
commented
10 months ago Heeelloo Junior 🚀
Good job on the third project, see below for comments :)
Organization of your files 📚
- Overall good organization of the repository, be careful with the .gitignore. you used .ignore instead. It won’t work like that, also make sure to ignore the useless files like DS.Store and ipynb checkpoints.
- Other than that try to have your functions in the folder called src, your files like csv or json in a folder called data, and your images in a folder called img. Like that your repository will be super clean!
README.md ✍🏽
- Your README is concise and straightforward. You explain what the project is about and what your objectives are.
- It’s great that you make decisions based on your findings, and that your conclusion sums up your project.
Tips to improve your Readme: Explain a bit more about your thinking process, show us why and how you got there. Add more images to better understand the project. Better explain your conclusion, maybe even add a Next Steps section to explain how you would improve it.
The code 👨🏽💻
-
Good job on the Mongo queries, everything is correct, you could’ve added more types of companies within the gaming industry to get more results.
-
Also good job on commenting what you are doing most of the time, it really helps when someone else is reading your code.
-
Regarding the Foursquare API, also good calls to the API, i recommend using categories sometimes when the result you want to get is more specific, like basketball courts or pet grooming places. https://location.foursquare.com/places/docs/categories By using the codes on the left you will only get the reliable results.
-
The code itself is good but a little chaotic, it is suuuper important to have your code in functions, like that it will also be much easier for you to use. And it will look much much cleaner.
Viz 🎨
- Good Visualizations! The map is nice and the objects you add to it too, I’d recommend putting them on the same map and with different color.
In general, your project looks good Junior! I would focus on the cleanliness of your code and trying to encapsulate it at the end of the project. Also try to base all your decisions on analysis instead of randomness!!
Congraats and good luck on the next one!
https://github.com/linharesjunior/project-III-geospatial-data.git