Open imfap1 opened 7 months ago
🗺️ Nice work! Some comments:
Repository Your repository is organized and the folder structure is clear.
README Your readme is informative and well developed, but this particular project is to get a location based on a particular set of needs and you didn’t make those needs clear here. You also don’t clearly state which was your chosen location, and part of the deliverables were to provide lat and long for the new office proposals. This README would benefit from an additional section showing the different needs you took into account and the final location: Using the Mongodb companies database, the first priority was to find the location with the most companies dedicated to video games that have raised more that one million dollars. The winner was San Francisco and there, we have five already established companies whose offices look like a good opportunity. To choose the best one, we calculate how many relevant venues are near, such as airports, train stations, bars, Starbucks, vegan restaurants and basketball stadiums and, applying different weights to prioritize each need, we can say that the offices of Exent (37.787646,-122.402759), in 658 Market Street, San Francisco, are our best bet.
Code I asked you for your notebook, to see your analysis of the information you got. Without it, it is hard to understand why you chose city_name_sf = "San Francisco". With the notebook, I see that it is the location with the highest videogames companies that have raised more than one million dollars. You did an excellent work with your encapsulation/modularization. A possible improvement would be to check again some of the foursquare results, like the df_designs_talks, because it includes a lot of beauty salons than have design in their name.
Maps Your maps are clear and it is a very good idea to include each of the maps with the different types of venues. I would recommend you add an image of the office_best_location map to your README too, because it is very easy to understand why you say this is the best location.
https://github.com/imfap1/Office-Locator