[ Esther ] - geospatial-data

[Estherkii]

https://github.com/Estherkii/project-III-geolocation

[sh-ih]

🗺️ Nice work! Some comments:

• Repository Great organization and folder structure. You also chose descriptive names for your files. Keep doing that! My only suggestion is to create a notebooks folder where to store all your Jupyter Notebook files. The common practice is to leave the src file for the .py files

• README Your readme is organized and informative. I really like how you clearly explained the different priorities that you took into account to choose the location.

To make it easier to read, I would suggest you to use breaklines to avoid big blocks of text like the second paragraph of your Hypothesis section.

Always be very mindful of a project's requirements. In this case, part of the deliverables was: “You must provide lat and long for the new office proposals.”. You gave us the name of the company previously occupying the office, but not the coordinates. It may seem like a small thing, but you don’t want to be in the middle of your presentation searching your notebooks (because you did include it there) to get longitude and latitude of the city center after your CEO asked you for them right there and then. Better to include it right here in the README and on your slides, and not only on the html map.

• Code The way you divide your code in different notebooks, each one with one main goal, is an excellent way of developing a project: it makes it easier to maintain and understand for people checking your repo.

Your use of subtitles and comments makes your notebooks very organized and informative.

The next step would be to concentrate the functions you already defined on .py files. You also have some for loops that need to be included inside functions so you can apply modularization/encapsulation and import those files to your notebooks to get even cleaner code.

• Maps The different types of venues of your maps are clearly marked. A possible improvement could be to also add a tooltip to show the name of the vegan restaurant, pet shop and other locations you are showing and only the type of store.