search

Ironhack-data-bcn-oct-2023 / project-IV-sql-tableau

0 stars 0 forks source link

https://github.com/psaeztorres/PROJECT-V #5

Open psaeztorres opened 9 months ago

psaeztorres commented 9 months ago

Patricia Sáez-Torres

sahernandezr commented 9 months ago

🐬📊Congrats on your project!

README Your README is informative and well organized. You could add more descriptive information about your datasets, for example, the period of time that is included or the kind of weather information being analyzed. The way you show your analysis and the visualizations right next to it is a great idea to show your work.

Code Great work with your .py files. By importing your cleaning module, you end up with a main,py with very clean code. One possible way to improve yout functions would be to add docstrings to each of them, explaining the goal of the function, the inputs it takes and its outputs.

SQL Your queries are well done and you show a great understanding of how to get the results you need to answer your questions. It is also very good that you include the comments of what do you want to get from each query.

Tableau Great job clearly presenting the objectives of your story as well as the conclusions. It is always the goal that your story can be understood completely on its own, in case someone reads this in Tableau and doesn’t have the repository as additional information.

It would be a good idea to add units to your graphs. For example, avg distance and duration in snow conditions, on light snow, 2,7508 is kilometers or miles? And the 13,400 is minutes? It is best practice to specify units of measure on your visualizations.

I really like how you included your analysis alongside the visualizations in the Tips section. You may want to do something similar for the other story points.