search

Ironholds / geohash

Geohash generation, decoding and manipulation in R
Other
40 stars 9 forks source link

Closes #12 -- adds gh column to gh_decode output to reflect received … #14

Closed MichaelChirico closed 6 years ago

MichaelChirico commented 6 years ago

…geohash names for convenience

happy to adjust the API as you see fit

MichaelChirico commented 6 years ago

@Ironholds done; Travis also revealed another issue, which is that it appears stringsAsFactors is TRUE by default here, so gh comes back as a factor. I guess this is probably preferred (geohash is a factor variable if ever there was one), so leaving as is.

Ironholds commented 6 years ago

I'd rather it as a string, to be honest; it maintains package consistency and I'd rather users make factors as an explicit choice!

MichaelChirico commented 6 years ago

@Ironholds done

Ironholds commented 6 years ago

Perf; thanks!