search

Ironholds / rgeolocate

Generalised IP geolocation through R
https://cran.r-project.org/web/packages/rgeolocate/index.html
Other
66 stars 22 forks source link

Field mismatch between ip_api() compared to ip-api.com directly #57

Closed jlacko closed 4 years ago

jlacko commented 5 years ago

There seems to be a mismatch in fields returned by R function and the IP-API website; to reproduce please compare results from: rgeolocate::ip_api("193.35.107.134") and https://ip-api.com/#193.35.107.134 - the website results look sensible, but those from the R function not.

Screenshot from 2019-10-17 16-42-00

vladc commented 5 years ago

This package parses the raw JSON line by line, and we've recently changed the order of the returned fields.

I did some previous work on a new version, but I didn't finish performance improvements/testing. Can you please test this? I'll make a pull request if everything seems ok https://github.com/vladc/rgeolocate/tree/batch

disclaimer: part of ip-api staff

jlacko commented 5 years ago

@vladc I have tried the batch branch (and not master as earlier) and yes, the results are correct.

Ironholds commented 4 years ago

Should now be fixed.