IrosTheBeggar / mStream

The easiest music streaming server available
http://mstream.io
GNU General Public License v3.0
2.22k stars 188 forks source link

Playback fails on filenames containing question marks #397

Closed tdammers closed 1 year ago

tdammers commented 1 year ago

Whenever I attempt to play a song that has a question mark in the title and filename, mStream pops up "Failed to play song".

A quick peek at the F12 console reveals that mStream does not encode question marks when making API requests:

scrot

This isn't just annoying, it could even pose a security risk - I haven't worked out a viable exploit, but it seems pretty obvious that anyone in control of filenames on the server can plant files whose filenames escape the URL path and leak query parameters into the URL.