Fix CPU number condition in service file

Irqbalance / irqbalance

The irqbalance source tree - The new official site for irqbalance

http://irqbalance.github.io/irqbalance/

GNU General Public License v2.0

586 stars 139 forks source link

Fix CPU number condition in service file #257

Closed middlingphys closed 1 year ago

middlingphys commented 1 year ago

Modified to start only when there are 2 or more CPUs, as intended in the original pull request (https://github.com/Irqbalance/irqbalance/pull/201).

ms178 commented 1 year ago

@nhorman This change causes a warning in dmesg with the following line:

[ +0,028967] systemd[1]: /usr/lib/systemd/system/irqbalance.service:6: Missing '=', ignoring line.

Seen with systemd-git 253.r62916.df40b7ef5a

CPU: Xeon 2696V3 (18C/36T - Haswell-EP)

Edit: I've verified that the warning is gone when I manually re-add the missing "=".

middlingphys commented 1 year ago

I was misunderstanding the syntax of the unit file. The original line was reflecting the condition as intended. I will submit a pull request to revert the change.