search

Irqbalance / irqbalance

The irqbalance source tree - The new official site for irqbalance
http://irqbalance.github.io/irqbalance/
GNU General Public License v2.0
576 stars 139 forks source link

Log spam in journald #292

Closed cpaelzer closed 8 months ago

cpaelzer commented 8 months ago

Hi, Ubuntu got this reported as a bug in 2046470. A check of the history showed me that this happened

  1. back in the initial import this was a debug message
  2. It got later converted to a log message and got INFO level (no more debug) but was unseen
  3. it was moved around when introducing sockets, still unseen
  4. recently not only foreground but also log_journal is auto-set

Combined that leads to Ubuntu, Debian and probably all other users of the recent version with change number 4 to get continuous journal entries like this every 10 seconds:

Jan 05 12:30:55 n-vm irqbalance[770]: 

                                      -----------------------------------------------------------------------------
Jan 05 12:31:05 n-vm irqbalance[770]: 

                                      -----------------------------------------------------------------------------
Jan 05 12:31:15 n-vm irqbalance[770]: 

                                      -----------------------------------------------------------------------------
Jan 05 12:31:25 n-vm irqbalance[770]: 

                                      -----------------------------------------------------------------------------
Jan 05 12:31:35 n-vm irqbalance[770]: 

                                      -----------------------------------------------------------------------------
Jan 05 12:31:45 n-vm irqbalance[770]: 

                                      -----------------------------------------------------------------------------

It grabs a lot of space and it does not say what it is about. That made sense back then when added as a message for the developer, but today is just annoying in the log.

I'd suggest to make this only shown in log level debug and to reduce the space it grabs as well as making it a bit more descriptive.

paride commented 8 months ago

Hi @cpaelzer, isn't this the same of of https://github.com/Irqbalance/irqbalance/issues/288 / https://github.com/Irqbalance/irqbalance/issues/281, hopefully fixed by https://github.com/Irqbalance/irqbalance/commit/f3282f4ddc10be44e6c423de6de8db600f748f85 ?

cpaelzer commented 8 months ago

You are right, thanks for going through closed issues. It wasn't in the context of the bad line so I missed it. I'll give this a try and if good close this and the PR.

cpaelzer commented 8 months ago

Confirmed, better fixing twice than not at all :-) But still closing this duplicate report - thanks