irqbalance-ui: check if using a negative index of buffer

Irqbalance / irqbalance

The irqbalance source tree - The new official site for irqbalance

http://irqbalance.github.io/irqbalance/

GNU General Public License v2.0

576 stars 139 forks source link

irqbalance-ui: check if using a negative index of buffer #299

Closed liutgnu closed 5 months ago

liutgnu commented 6 months ago

A negative index will be used when recv() fails, which is unexpected for the data buffer.

liutgnu commented 5 months ago

Hi @nhorman,

The issue was found by Static Application Security Testing (SAST), which is a potential weakness IMHO. Could you please have a review to see if it should be fixed?

Thanks!

nhorman commented 5 months ago

yeah, looks legitimate. Send a PR?

liutgnu commented 5 months ago

yeah, looks legitimate. Send a PR?

Hi nhorman,

The PR link is: https://github.com/Irqbalance/irqbalance/pull/299/files. Not sure if this is what you want.

Thanks!