search

Irrational-Encoding-Wizardry / guide.encode.moe

A guide for fansubbing
https://guide.encode.moe
Creative Commons Attribution Share Alike 4.0 International
141 stars 20 forks source link

Write basics of x264 guide #41

Closed shssoichiro closed 4 years ago

shssoichiro commented 4 years ago

I just saw that #38 exists, but fortunately it looks like there's not much overlap at the moment, as mine is a very intro-level guide. Going through each of the x264 options is what I intended to do for the Advanced section. @pwinner if you don't mind, I'd like to use your branch as a starting point for the Advanced section, but wanted to communicate first so there's no duplicate work going on (if you're still actively working on it).

MysteryDove commented 4 years ago

Great! I'm considering the easy mode too. I'll keep pushing forward my part.

FichteFoll commented 4 years ago

How general are the concepts of 1-pass, 2-pass and CRF encoding? If they apply to many codecs (and I think they do), we might better move this to a the general encoding page and explain these concepts with the example of x264.

This page generally reads more like a guide than a reference, which I definitely like, but this might not be the correct page for it. You don't have to address this point within this PR, as I can work on how I imagine it later, but I'd like to talk about it first and hear some input.

MysteryDove commented 4 years ago

How general are the concepts of 1-pass, 2-pass and CRF encoding? If they apply to many codecs (and I think they do), we might better move this to a the general encoding page and explain these concepts with the example of x264.

There's QP, CQP, CRF, VBR, CBR in these codecs. I think they're a better start point than 1-pass, 2-pass, etc. Shall we introduce them first?

shssoichiro commented 4 years ago

I agree, I think it makes sense to have an overview of the general concepts in the top level Codecs page, and guides/implementation details on the specific codec page (e.g. this one). So there's definitely some room to split up the 1-pass, 2-pass, and CRF sections into the main page.

FichteFoll commented 4 years ago

This PR is a prime example of how I imagine this collaborative effort to work. :+1: Thanks for the help on this, everyone, and of course @shssoichiro. I'm satisfied with this as is and am going to merge now.

@OrangeChannel, please do the katex integration in a separate PR. You can add a sentence or two regarding ordered lists on the master branch directly.