Closed OrangeChannel closed 3 years ago
That must have been a lot work, so thanks a lot for that.
Before I start to review this some time over the next week(s), could you give me a summary over the effective differences between our previous gitbook instance and what mdbook can do? Do we have feature parity?
PROS :heavy_check_mark: :
serve
at least from my tests, but the pages for some reason seem to become styled after the content is loaded (MathJax builds the equations when you load the page, not before)$$
problem the KaTeX plug-in did[^2]
at the bottom)CONS: :x: :
Edit this page on GitHub
<TODO>
with just TODO
Some features I've brought over or already existed on both worth mentioning:
![this text](image.png)
doesn't show anywhere
I've changed the formatting so img + em
css rules catches the following and shows the caption centered and under the picture. Though, the captions aren't numbered automatically like in the old plug-in.
copy this code
symbol at the top rightThanks again for your work on this and sorry for taking such a long time.
We now have working CI and CD again in an almost blazingly fast github action, artifact download included.
Next time, you could also push to a branch on this repo, btw. You're a collaborator for a reason. :wink:
Somewhat fixes https://github.com/Irrational-Encoding-Wizardry/guide.encode.moe/issues/60 but still missing the relevant GitHub action to build to the gh-pages branch, as I'm not exactly sure how to do this and I can't get the book to work for my repo's pages (though I can preview the files just fine). We can still use Travis as the CI tool with this.