Irrational-Encoding-Wizardry / guide.encode.moe

A guide for fansubbing
https://guide.encode.moe
Creative Commons Attribution Share Alike 4.0 International
141 stars 20 forks source link

Switch from legacy gitbook to Rust's mdBook #61

Closed OrangeChannel closed 3 years ago

OrangeChannel commented 3 years ago

Somewhat fixes https://github.com/Irrational-Encoding-Wizardry/guide.encode.moe/issues/60 but still missing the relevant GitHub action to build to the gh-pages branch, as I'm not exactly sure how to do this and I can't get the book to work for my repo's pages (though I can preview the files just fine). We can still use Travis as the CI tool with this.

image image

FichteFoll commented 3 years ago

That must have been a lot work, so thanks a lot for that.

Before I start to review this some time over the next week(s), could you give me a summary over the effective differences between our previous gitbook instance and what mdbook can do? Do we have feature parity?

OrangeChannel commented 3 years ago

PROS :heavy_check_mark: :

CONS: :x: :

Some features I've brought over or already existed on both worth mentioning:

FichteFoll commented 3 years ago

Thanks again for your work on this and sorry for taking such a long time.

We now have working CI and CD again in an almost blazingly fast github action, artifact download included.

Next time, you could also push to a branch on this repo, btw. You're a collaborator for a reason. :wink: