search

IrrigationProtocol / irrigation-contracts-diamond

MIT License
3 stars 1 forks source link

Create BeanStalk Interface .sol file #4

Closed SuperGNUS closed 1 year ago

SuperGNUS commented 1 year ago

Use abi-to-json and create an updatable bash script based on updated to the abi json file

SuperGNUS commented 1 year ago

This is done, but I think I'll change how this works to directly pull the Interfaces from the BeanStalk repo or create a dummy npmjs package for just the interfaces to use.

ruymaster commented 1 year ago

Beanstalk means diamond root in beanstalk protocol, so Beanstalk interface has every functions for all facets in beantalk. for example, transferPlot is the function of MaketplaceFacet contract in beanstalk project. So I think that it is not possible to directly pull for beanstalk interface sol file from Beanstalk repo. And we don't need all functions in this root interface, so we need to make simple interface that includes only we need.

SuperGNUS commented 1 year ago

Right, I started to do that and instead will use the .json file from the repo to generate the main diamond functions. This was manual and used abi-to-sol to generate the file. I did have to manually remove the IDiamond* interfaces as they interfered with ours.