IrrigationProtocol / irrigation-contracts-diamond

MIT License
3 stars 1 forks source link

Change auction fee into ETH, not token #58

Closed ruymaster closed 1 year ago

Super-Genius commented 1 year ago

This should be changing auction listing fee into ETH and closing Fee is taken from successful auction fees that the buyer paid in Whitelisted assets for buying (i.e. Stable Coins percentage)

Super-Genius commented 1 year ago

Going to update Notion.

@ruymaster We need a mapping of stored water holdings -> listing fee, successful auction fees.

This way we can charge non-water holders 1% listing fee and 1.5% successful auction fee.

Then an admin (only) can later or even now set this for and example.

water amount 32 -> .75% listing fee and 1.25% successful auction fee water amount 10000 -> 0% listing fee and 0.5% successful auction fee

ruymaster commented 1 year ago

So, only when listing token on auction market, contract will check holding water, right?

Super-Genius commented 1 year ago

Anyway to check the amount of water they continued to store during the auction period?

That way they need to keep it locked/stored or a pro-rata amount to determine the closing percentage fees?

Like if they stored 3200, did the auction then unstored all, the success % would be calculated on the stored average water during the auction period and chose the 0 water lookup in this case.

ruymaster commented 1 year ago

Sure, I think that it is possible. There are several transactions like creating, bidding, and buying, on one auction. So, contract can record holding water per each transaction for one auction.

ruymaster commented 1 year ago

Currently, didn't implement getting average stored water. It increases gas fee and I think it is better to keep only stored water.