search

IrrigationProtocol / irrigation-contracts-diamond

MIT License
3 stars 1 forks source link

58 change auction fee #62

Closed ruymaster closed 1 year ago

ruymaster commented 1 year ago
ruymaster commented 1 year ago

In general, I think the user can game the system because the success fee % is checked at the closing of a successful auction. They could store 3200 water and get a low percentage success fee, put up a 30 day auction, unstore their water for 29 days, then restore 3200 just before the auction closes.

I think we should be able to figure out how to set some variable that is added to and subtracted from their water holding and a function that says between these two timestamps get the average.

Trying to think about it more It is possible to get average of stored water, but it will increase gas fee. Also, even if users will store and unstore while auction period, it will increase the volume for our protocol transactions. I think that it is not bad.