Old selectors are not deleted

IrrigationProtocol / irrigation-contracts-diamond

MIT License

3 stars 1 forks source link

Old selectors are not deleted #68

Closed ruymaster closed 1 year ago

ruymaster commented 1 year ago

When upgrading old facet to new facet, the selectors that are not in new facet should be deleted.

Super-Genius commented 1 year ago

That's interesting because the typescript scripts in gnus-ai contracts for deployment have this functionality.

ruymaster commented 1 year ago

While testing upgrade script, I found some old selectors are not removed on diamond. For example, I updated parameters in getAuctionFee function. If I upgrade contract with new getAuctionFee function, old getAuctionFee function selector should be deleted. But it is not deleted.

ruymaster commented 1 year ago

Done