IrvKalb / pygwidgets

A collection of user interface widgets in Python for use in programs using Pygame.
BSD 2-Clause "Simplified" License
11 stars 5 forks source link

Radio button image file names in Main_Test_pygwidgets.py are not camel cased #8

Closed colinhoad closed 1 year ago

colinhoad commented 1 year ago

The image path values in Main_Test_pygwidgets.py for the radio button PNGs are not in camel case (they all start with upper case R whereas the image files themselves all start with lower case r). As a result, Main_Test_pygwidgets.py errors when run.

IrvKalb commented 1 year ago

Thanks for letting me know about this. I do my development on a Mac, and in file names, case does not matter - so I never saw this error. I have modified the code to use camel case for the radio buttons.

colinhoad commented 1 year ago

Ah, that explains it - I was running the script on Raspbian Linux, which is case sensitive! Thank you for the excellent OOP Python book, I'm really enjoying it and have learnt so much from it.

On Mon, 29 May 2023, 19:06 Irv Kalb, @.***> wrote:

Thanks for letting me know about this. I do my development on a Mac, and in file names, case does not matter - so I never saw this error. I have modified the code to use camel case for the radio buttons.

— Reply to this email directly, view it on GitHub https://github.com/IrvKalb/pygwidgets/issues/8#issuecomment-1567395958, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4ILHIWXQJAIMHQLJO3NPTXITQRJANCNFSM6AAAAAAYS7V7VM . You are receiving this because you authored the thread.Message ID: @.***>

IrvKalb commented 1 year ago

Very glad to hear that you are enjoying the book! In the introduction, I wrote that I have tested all the code on Macs and on Windows systems, but I am not a Linux/Unix guy so I never tested it there. Please let me know if there are any other cases where the code doesn't run on you system, and I will be happy to fix the code.
I expect to be publishing an updated version of my "pygwidgets" and "pyghelpers" soon with additional features. I needed to add some things to support a game that I expect to ship shortly. Coming soon ...

IrvKalb commented 1 year ago

Please let me know if my change fixed the problem for you. If so, I will close this issue.

colinhoad commented 1 year ago

Thank you, yes - happy to confirm the issue is resolved and the program runs without error on Linux! Looking forward to the new features coming soon.

IrvKalb commented 1 year ago

Great. Closed.