IsSuEat / open-livestreamer-firefox-addon

Addon for firefox to quickly open stream urls in vlc using livestreamer
GNU General Public License v3.0
18 stars 7 forks source link

Stuck on "Launching Livestreamer" when using mpv on OS X #49

Closed bramcordie closed 8 years ago

bramcordie commented 8 years ago

On OS X I can't use livestreamer from the browser to launch mpv without specifying the full path to the player. I first tried to configure livestreamer to use mpv in the .livestreamerrc config file but then the add-on gets stuck on Launching Livestreamer. Using livestreamer from the CLI, with the same default config, does launch mpv without a problem.

When I used the linux example arguments from the wiki the add-on was again stuck on Launching Livestreamer. Here the argument that specifies the player just says mpv like you would expect.

I'm not sure if this is a quirk in the add-on or if livestreamer itself is to blame. I'm guessing the former because launching from the CLI works fine.

I ended up pointing livestreamer to the bin path in optional arguments of the add-on config. This resolves the problem. My config has been added to the wiki as an example:

  • OS X (livestreamer and mpv installed using [Homebrew]):
    Path to livestreamer /usr/local/bin/livestreamer
    Stream quality best
    Optional arguments for livestreamer --player=/usr/local/bin/mpv --no-cache
IsSuEat commented 8 years ago

Yup, this is known. The problem here is, afair, that the environment variables don't get resolved, thus your $PATH variable is probably empty. I don't really know if there is a workaround for this, so for the time being the full path must be specified

Thanks for adding it to the wiki!