[BUG] Market Transaction Stats does not account for multiple currencies

[Talha-Ak]

Expected Behavior

The Market Transactions stats component should accumulate currencies separately with a total for each currency, or convert additional currencies to the account's main currency before showing total.

Actual Behavior

(I suspect) currencies are disregarded and are all treated the same, leading to very inaccurate totals. I also suspect the problem is exacerbated due to certain currencies using a period as a separator, while others use a comma. Goes without saying, but I have not earned £35 000 off the market.

Steps to Reproduce the Problem

1. Complete market transaction on existing currency
2. Change Steam account to a different currency
3. Complete market transaction on new currency

Specifications

• Augmented Steam Version: 2.6.0
• Browser Version: Chrome 117.0.5938.88 (Official Build) (64-bit)

[candela97]

So when you change your wallet currency, past market transactions stay in the same currency they were processed? Can you show a screenshot that verifies this behaviour? You can view market transactions by clicking on the "My Market History" tab.

[Talha-Ak]

Yes, past transactions remain in the same currency they were purchased in. The currency change doesn't happen within the same "page" of results (for my account) but here are a few transactions back-to-back:

[candela97]

This is a tricky one. We can detect the currency by matching currency symbols, but apparently RMB and JPY share the same symbol 😅

[Talha-Ak]

Is it possible to pull in info from purchase history? From what I can see, it seems to render the currency code and country as a separate entry in that table every time a conversion happens.

[candela97]

Hmm, but don't existing listings stay in the same currency they were listed in prior to conversion?

[Talha-Ak]

Yes, they do. (see below comment)

What I'm thinking is (I have no idea if this is actually practical):

• If all market transactions are in the same currency (i.e. no "currency conversion" in history), keep the stats as-is currently.
• If there are currency changes (can be detected either by checking symbol or checking for "currency conversion" in history), cross-reference the date of conversion with listings made on/after that date to get the correct currency code.

That (should?) work around currencies using the same symbol.

[Talha-Ak]

don't existing listings stay in the same currency they were listed in prior to conversion?

Sorry, maybe I misunderstood this, let me clarify.

When an account's currency is changed, all listings currently active at the time of conversion get cancelled by Steam, so it's not possible to sell an item in a different currency to what the account currency is.

This looks different to a user removing a listing:

Listings that have already sold prior to currency conversion will show what they sold at in the currency the account/listing was previously in.

[candela97]

Oh, so they get canceled, that's good to hear. Anyway, we can probably workaround the symbol thing with some extra heuristics, since it's just 2 currencies that have this problem.

We should continue using the market history to calculate this though. Using the purchase history will make this feature cross-domain, which opens up a new can of worms.

[Talha-Ak]

Not sure if I'm stepping on anyone's toes if this is being worked on already, but I've put together a quick PoC:

This doesn't take into account the CNY/JPY issue. Could probably check if "Cancelled by Steam" shows up between currencies to identify a change, but won't be able to determine which currency is which like that. Unless another heuristic is accessible from here?