IsThereAnyDeal / AugmentedSteam

Augments your Steam Experience
https://augmentedsteam.com
GNU General Public License v3.0
1.31k stars 85 forks source link

Fix detecting inventory gifts #1892

Closed candela97 closed 2 months ago

candela97 commented 3 months ago

Didn't test this, just ported the original logic from ES and simplified a bit.

Fixes #1779.

tfedor commented 2 months ago

I think I'm missing something, because I don't see how this fixes anything? It's just rewriting the same logic, without addressing the issu in #1779, right?

candela97 commented 2 months ago

This precisely fixes the issue as mentioned: .type was accessed on the wrong object (data.descriptions.descriptions instead of data.descriptions), although I didn't check if there's anything else broken.

Weird that nobody reported this, this bug has been there since the beginning 😅

tfedor commented 2 months ago

I see, thank you