Closed candela97 closed 2 months ago
I think I'm missing something, because I don't see how this fixes anything? It's just rewriting the same logic, without addressing the issu in #1779, right?
This precisely fixes the issue as mentioned: .type
was accessed on the wrong object (data.descriptions.descriptions
instead of data.descriptions
), although I didn't check if there's anything else broken.
Weird that nobody reported this, this bug has been there since the beginning 😅
I see, thank you
Didn't test this, just ported the original logic from ES and simplified a bit.
Fixes #1779.