search

IsThereAnyDeal / AugmentedSteam

Augments your Steam Experience
https://augmentedsteam.com
GNU General Public License v3.0
1.31k stars 84 forks source link

[BUG] Achievement Sorting By Date Unlocked Does Nothing #1908

Open mslowikowski opened 2 months ago

mslowikowski commented 2 months ago

Expected Behavior

Achievements are ordered the date that they were unlocked according to the Ascending/Descending toggle when the Sort By drop down is set to Date Unlocked

Actual Behavior

Achievements are ordered by the default order set by Steam

Steps to Reproduce the Problem

  1. Log-in to steam
  2. Navigate to an achievement page (https://steamcommunity.com/id//stats//achievements/)
  3. Change Sort By drop down to Date Unlocked

Specifications

candela97 commented 2 months ago

Are there any errors in the browser console (F12)?

mslowikowski commented 2 months ago

Are there any errors in the browser console (F12)?

No there are no errors in the console.

Sakr3d commented 2 months ago

This occurs for me in Chrome as well. Chrome version: 124.0.6367.61 (Official Build) (64-bit), Augmented Steam version: 3.1.1

Console log shows the following: profile_stats.js:66 Augmented Steam v3.1.1 https://augmentedsteam.com profile_stats.js:7 Feature loading complete, 7 successfully loaded, 0 failed to load, 0 didn't load due to dependency errors achievements/:1 Uncaught (in promise) Error: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received

steamcommunity.com-1713792226240.log

candela97 commented 2 months ago

Can you test it on a brand new browser profile with only AS enabled?

Sakr3d commented 2 months ago

Created new Chrome Profile, installed augmented steam. No other extensions installed.

image

candela97 commented 2 months ago

Can I ask what language your browser is set to?

Sakr3d commented 2 months ago

I tried it with English (US) at the top and with English at the top. Same issue.

image

candela97 commented 2 months ago

I'm out of ideas, so I've created a build with extra logging to help see what's going on. If you'd like to help, please visit https://github.com/IsThereAnyDeal/AugmentedSteam/actions/runs/8790487939, scroll to the bottom, download a build for your browser and side-load it. For Chrome, you'll have to enable developer mode then load unpacked; for Firefox, go to about://debugging.

This shouldn't mess with your existing install, but you can backup your settings, or test in a separate browser just in case. Note that you do not need to log in to Steam to use this feature, as long as your games list is set to public.

Next, open your achievements page and make sure it's in English. If not, add ?l=english to the URL. Open the browser console, and select sort by date unlocked. You should see something like this in the console (click on the arrow to expand): 螢幕擷取畫面 2024-04-23 041307

Sakr3d commented 2 months ago

Here's the log.

steamcommunity.com-1713821286248.log

My console is not showing FAchievementSort.ts like your image is. I'm showing profile_stats.js

candela97 commented 2 months ago

Thanks, I got it. Date formats are region-dependent, so there're 2 types for English, month/day and day/month.

candela97 commented 2 months ago

Please give this branch a test under your normal setup and see if it works https://github.com/IsThereAnyDeal/AugmentedSteam/actions/runs/8802153019

Sakr3d commented 2 months ago

Sorry for the delay. I tested the branch and sorting worked as expected.

image