search

IsThereAnyDeal / AugmentedSteam

Augments your Steam Experience
https://augmentedsteam.com
GNU General Public License v3.0
1.4k stars 86 forks source link

Unable to Full screen videos/trailers #252

Closed shatteredhalo closed 4 years ago

shatteredhalo commented 5 years ago

With the Augmented Steam extension enabled, clicking the full-screen button on the Steam media player does nothing. Disabling the extension allows videos/trailers to once again be properly set to full-screen.

Chrome 66.0.3359.181

aug

KarlCastle commented 5 years ago

Hi, thanks for reporting this.

Unfortunately I can't replicate it on current Chrome (73.0.3683.103 x64), so we'll need more information to try and fix it.

Does the icon react if you hover over it? It should be grey normally and go white when the mouse cursor is over it.

Do you know how to check the browser console for errors? (And if so, are there any? Either before you click on the button, or after?)

Does the HD toggle work?

shatteredhalo commented 5 years ago

Hi, thanks for reporting this.

Unfortunately I can't replicate it on current Chrome (73.0.3683.103 x64), so we'll need more information to try and fix it.

Does the icon react if you hover over it? It should be grey normally and go white when the mouse cursor is over it.

Do you know how to check the browser console for errors? (And if so, are there any? Either before you click on the button, or after?)

Does the HD toggle work?

It does react. It is grey normally and turns white on mouse cursor hover.

I have attached a screenshot of the browser console readout from a freshly loaded page. Hovering or clicking the full screen button does not create any new entries/errors.

The HD toggle works correctly.

aug1

KarlCastle commented 5 years ago

The CORS error is weird. Akamai are absolutely serving it with the correct header, so something has to have stripped it en route. Nothing to do with us though.

I've tried getting a working build of Chrome/Chromium 66 to test with and no dice, just startup crashes :(

The button uses the HTML5 fullScreen API which Chrome has lagged behind in implementing, but none of the features we rely on have changed since Chrome 53.

Does double-clicking on the video toggle fullscreen?

shatteredhalo commented 5 years ago

Unfortunately double clicking does not work either.

shatteredhalo commented 5 years ago

I should probably add to the double clicking comment: while it does not fullscreen, it does pause/unpause the video.

shatteredhalo commented 5 years ago

Also for what it's worth, version 10.0 of Enhanced Steam doesn't have this issue, and full screens properly.

KarlCastle commented 5 years ago

My working assumption is that we're relying on something (don't know what exactly) that changed in some (undocumented?) way between Chrome 66 and Chrome 74. Since Google makes older versions of Chrome so hard to obtain we don't officially support anything but the latest version.

It seems like something is going wrong in the event handler but without an error message, and with no ability to replicate the error in a test environment, it makes troubleshooting exceedingly difficult.

MxtOUT commented 5 years ago

@shatteredhalo Any news on this?

shatteredhalo commented 5 years ago

@MxtOUT I actually switched back to the closed/deprecated Enhanced Steam over this issue since the way Karl explained it, seeing a fix in Augmented Steam seemed unlikely. I can try Augmented again if a related fix has gone in...?

shatteredhalo commented 5 years ago

Just an update to confirm that the newest version of Augmented Steam (1.2.1) still has this issue for me.

MxtOUT commented 4 years ago

Still not working? Have you tried it with the latest Chrome?

shatteredhalo commented 4 years ago

It does seem to work on newer versions of Chrome. On this machine I have 76.0.3809.100 (Official Build) (64-bit) and the full screen functions as expected.

MxtOUT commented 4 years ago

Ok, then I'll close it, since we're only supporting the newest Chrome