IsThereAnyDeal / AugmentedSteam

Augments your Steam Experience
https://augmentedsteam.com
GNU General Public License v3.0
1.4k stars 87 forks source link

Nonsense Price-Suggestions #274

Open Eiion opened 5 years ago

Eiion commented 5 years ago

So I wanted to use the "Sell these cards on the Market" feature - turns out the prices suggested are complete nonsense! Example: On the badges page the currently lowest price shown for the card is 9 Euro Cents Screenshot On the market page for the card the card actually is 9 Euro Cents (which is a surprise, given that half the time the actual price is either less or more than what's displayed on the badge page) Screenshot 1 On the "Sell multiple items" page for the badge the card gets automatically listed with 7 Euro Cents! Screenshot 2

What's up with that? Why two Cents less than the current lowest price? Why not match the price or make it 1 Cent less the most?

I have no idea why there's no setting to adjust the minimal price (e.g. "+/- 0" or "-1" Cent of the current lowest price) and where you pull these prices. In case the country URL to pull market prices you're using are any different from the users's market URL, the prices won't match and if you take even different ones as basis to calculate selling prices, things like this comes up.

Would you please fix this? Thanks!

EDIT: Checking more prices, suggested selling prices and actual prices differ up to 5 Cents for this particular set. ...that's just quite ridiculous. Screenshot Screenshot 1 Screenshot 2

MxtOUT commented 5 years ago

I tracked this down to be a server side bug, the prices are getting rounded (e.g. I'm getting 0.0717208 as a value). This probably is caused by converting between currencies

MxtOUT commented 5 years ago

About the problem with the multisell: This page is not modified by AS, I also don't get why the initial prices don't match the current lowest price

Eiion commented 5 years ago

A user setting where we can select our country (to use our local store and market prices), maybe even input the local market url as a starting point to modify sources automatically, would make price conversions redundant.

The sources are there and they should be used. Converting currencies makes no sense in these regards.

MxtOUT commented 5 years ago

I know, but I can't do anything on the server side. AS is already capable of reading the store currency

infekSK commented 5 years ago

This has to be from AS, another extension which automates trading always selects the current lowest price.

MxtOUT commented 5 years ago

Do you mean the multisell site? I tried it without AS and it still selects the wrong prices

infekSK commented 5 years ago

No it was Steam Inventory Helper. Wouldn't recommend downloading it though because they changed permissions recently and it became a little sketchy.

MxtOUT commented 5 years ago

I think we're talking about two different things here. I meant the multisell site that is offered by Steam natively and you mean the function to automatically adjust the sell price of an item on the inventory page

Eiion commented 5 years ago

Please explain, why can the source of information regarding community market prices not be changed according to the user's location? One would think expanding the extensions code to add such a feature would be possible. It only makes sense to not show false prices anywhere outside (presumably) the US.

And I have to agree with infekSK - Steam Inventory Helper can do it. That's what I've switched back to in order to get correct prices.

MxtOUT commented 5 years ago

The function of the API server is to reduce server load for the Steam Market servers. Technically it is possible to fetch this information from the client side (I guess we're still doing this for quick selling).

So yeah, as I said, I'm unable to fix this problem without any server changes made by @tfedor

Eiion commented 5 years ago

Well then, lets hope @tfedor is interested in fixing the issues with his extension. Thanks for the providing info @MxtOUT .

MxtOUT commented 5 years ago

I'm sure he is, but I know that he has other things to do

tfedor commented 5 years ago

I've tried setting up market data update more often, to make sure this is not the case of old data.

I don't think Steam has regional prices for market data.

Please let me know if it helped.

Eiion commented 5 years ago

I'm not sure if I got you right @tfedor, but yes, Steam should have data for regional prices as there's indeed a difference in regional market prices (for e.g. trading cards and such).

MxtOUT commented 5 years ago

@Eiion Do you still observe this behavior?

Eiion commented 5 years ago

@MxtOUT Oh yeah, that's definitely still an issue. Prices given on the badge page and actual lowest prices on the market do not match! As the last screenshot shows, the quick sell option on the inventory seems to get price data from the correct source.

Lowest price as per badge page: Screenshot 4

Lowest price item market page: Screenshot 1

Prices on iventory page for lowest market and suggested selling price: Screenshot 2

Unfortunately I don't have the time right now to search for cards with even bigger price differences.

BTW: This also is problematic in regards of using the quick sell button in the inventory.

Xarnowit commented 1 year ago

This issue still seems to be present, but for me price differences between what is shown on game badge page and real prices seem to be much greater (sometimes ~2x). I don't think that the issue is old data, unless price data is refreshed like once a month or something (just by looking at median price graph for Aster Pien)

Example game: "Fates Of Ort", take a look at 14/15 Fates Of Ort Badge Page

Market info for that card. Notice price is 50% of what is shown on badge page Aster Pien Market

Avg Price last month for the card Aster Pien Graph

I also looked at the api call just in case it was some currency mixup but it seems fine, request is for card price in PLN and result is what is shown (after rounding)