IsThereAnyDeal / AugmentedSteam

Augments your Steam Experience
https://augmentedsteam.com
GNU General Public License v3.0
1.39k stars 86 forks source link

Developer link replacement searches publisher #674

Closed NLZ closed 4 years ago

NLZ commented 4 years ago

The developer link replacement is bugged, searches for publisher instead of developer: image

Seems like this line is the culprit, but I leave it up for the experts to troubleshoot: https://github.com/tfedor/AugmentedSteam/blob/b6c5f7e814e42f64ba759de54781b6219ab8abbb/js/content/store.js#L2999

MxtOUT commented 4 years ago

Just if you're interested, the line you mentioned affects the hide buttons on the search page.

Thanks for reporting!

candela97 commented 4 years ago

Seems like franchise links (if present) are broken as well... https://store.steampowered.com/app/582010/MONSTER_HUNTER_WORLD/ https://store.steampowered.com/app/813780/Age_of_Empires_II_Definitive_Edition/ I think they shouldn't be modified.

bestpika commented 4 years ago

Did this version publish to the Chrome web store? I saw some page's link still wrong.

candela97 commented 4 years ago

Can't reproduce on latest stable Chrome, and the commits that fixed this issue didn't affect this area. 註解 2020-01-22 055757

bestpika commented 4 years ago

🤔 Yesterday, the link is wrong. Today, the link is correct.

Maybe the issue is Steam's issue...

bestpika commented 4 years ago

It has happened again. image

Maybe it was caused by another extension?

This is okay. image

This is wrong. image

I also install https://chrome.google.com/webstore/detail/kdbmhfkmnlmbkgbabkdealhhbfhlmmon. But this extension does not modify the links. It added some links to the block.

This is my configuration. chrome-extension___kdbmhfkmnlmbkgbabkdealhhbfhlmmon_options_options html

Revadike commented 4 years ago

I can confirm this happens when using steamdb's extension. Can't we check the curator link in order to determine if it's a dev or pub?

MxtOUT commented 4 years ago

Better to open a new issue

Revadike commented 4 years ago

Better to open a new issue

Do you think we can check the curator link in order to determine if it's a dev or pub?

MxtOUT commented 4 years ago

Should be possible, yes

Revadike commented 4 years ago

Should be possible, yes

No, because the link path can be /curator/ too and then what?