search

IsThereAnyDeal / AugmentedSteam

Augments your Steam Experience
https://augmentedsteam.com
GNU General Public License v3.0
1.39k stars 86 forks source link

Developer and Publisher search mixed up #909

Closed hgdagon closed 4 years ago

hgdagon commented 4 years ago

When replacing developer/publisher homepage links to search (awesome feature, btw), the links are mixed up should be the other way around. Noticed just now, so it must have been introduced in one the latest updates.

Revadike commented 4 years ago

I thought we fixed this. What store page?

hgdagon commented 4 years ago

Um... every page?

hgdagon commented 4 years ago

Hmmm... Actually no, not every not every page. I don't remember which page I noticed it on when I started this issue, but now, on Serena's page it's mixed up, on Payday 2 it's not... So, yeah... at least 2 pages.

Revadike commented 4 years ago

I can't find Serena's page, can u link me?

hgdagon commented 4 years ago

@Revadike https://store.steampowered.com/app/272060/Serena/

As you can, for this particular game, the developer and publisher are the same. so it's not as big of a deal. However, the one I noticed first, was not published by the developer, so it would open empty search pages.

Revadike commented 4 years ago

@Revadike https://store.steampowered.com/app/272060/Serena/✔

Looks fine to me. Are you sure you're on the latest version of AS?

hgdagon commented 4 years ago

Looks fine to me.

On my side it's still switched. I also found a few other examples, but they have the same developer and publisher.

Are you sure you're on the latest version of AS?

I'm not... It's weird, I'm on 1.4.0, mozilla page says 1.4.6, but when I press "check for updates", it says "no updates found". Anyway, seems like the problem on my side. Sorry for wasting your time.

P.S. the new GitHub does not send me notifications for this issue. WTF?

Revadike commented 4 years ago

So, did the update fix it?

hgdagon commented 4 years ago

It did, yes. I had to uninstall, and then manually reinstall from Mozilla's website. Waterfox's add-ons manager page says 1.4.6 is incompatible (which is probably why it wasn't updating), yet I do see the changes on Steam. What sucks is it seems like I'm gonna have to update manually every time...

Revadike commented 4 years ago

Maybe close this and open a new issue for the update bug.

candela97 commented 4 years ago

Minimum browser version has been bumped to Firefox 57 since 1.4.1, so WaterFox might not be supported.