search

Isabellanamutenda / recipe-App

0 stars 0 forks source link

Ruby on Rails Capstone Project #5

Open Isabellanamutenda opened 2 years ago

Isabellanamutenda commented 2 years ago

Ruby capstone project

AshakaE commented 2 years ago

Hi @Isabellanamutenda 🙋‍♀️,

Good job so far! 👌 There are some issues that you still need to work on to go to the next project but you are almost there!

Everything looks great but the points per task - [x] Please specify the amount per task in the place of `X` for each task. Rather than `[Xpt]` , it should be something like `[2pt]` or `[0.5pt]` # Required Changes ♻️ 🚧 _Check the comments under the review._ ### Optional suggestions _Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better._ Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. **_Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise._** ------ _As described in the [Code reviews limits policy](https://microverse.zendesk.com/hc/en-us/articles/1500004088561) you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using [this form](https://airtable.com/shrQAqnBwek5a0O0s)._
Isabellanamutenda commented 2 years ago

Thank you fixed

AshakaE commented 2 years ago

Hi @Isabellanamutenda 🙋‍♀️,

STATUS APPROVED ✔

Your project is complete! There is nothing else to say other than... it's time to merge it 🔗 🚢 Congratulations! 🎉

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers 🥂 and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Isabellanamutenda commented 2 years ago

Thank you so much:slightly_smiling_face: