search

IsakZhang / Generative-ABSA

86 stars 16 forks source link

code is incomplete in main.py line 332。 #2

Open scarydemon2 opened 2 years ago

scarydemon2 commented 2 years ago

the evaluate func is define as : def evaluate(data_loader, model, paradigm, task, sents): but parameter not passed in :https://github.com/IsakZhang/Generative-ABSA/blob/8f4671b2a4cbda6ebca1ab1462a4ce7607e0aed1/main.py#L332 It seems that the eval process is not finished, can you add the complete code?

CodeWang-Ay commented 2 years ago

you can try below code like test code : sents, _ = read_line_examples_from_file(f'data/{args.task}/{args.dataset}/dev.txt') dev_result = evaluate(dev_loader, model, args.paradigm, args.task, sents)

IsakZhang commented 2 years ago

Thanks @kingbuff for answering the question. Since I did not use "do_eval" in the final experiment, I forgot to change the code of that part when releasing. You can modify that part similar to "do_direct_eval". I will update the code later when I have more free time. Thanks.

CodeWang-Ay commented 2 years ago

Do the experimental results of the ASTE task in your paper report a development set or a test set?