IsenrichO / noto

Automatically exported from code.google.com/p/noto
0 stars 0 forks source link

Code review request #339

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name: lint-cjk

Purpose of code changes on this branch: fixes website data generation

r7866c89d12af makes three changes:
 - adds license files to the zips, either SIL or Apache or both, depending
   on the zip contents
 - uses 7za to compress all the zips, it's faster and generates smaller
   files than the previous use of zip and then recompressing with advzip.
   7za has to be invoked via a subprocess, and doesn't rename files as
   we used to do with the python zip api, so code was added to handle cases
   of file renaming (and subpath removal).
 - no longer deletes two unused subdirectories that are used/built during
   the process and then scrapped at the end.  this is a quick fix so the
   tool can be rerun with an existing directory to patch files (for example,
   regenerate a few image files) without regenerating the whole directory
   from scratch, which takes hours.  formerly, when these directories were
   deleted, trying to rebuild fails because other code expects them to
   exist

When reviewing my code changes, please focus on: the usual

After the review, I'll merge this branch into:
/master

Original issue reported on code.google.com by dougf...@google.com on 21 Apr 2015 at 10:46