Open francepack opened 4 years ago
@francepack I've went ahead and made the changes I believe you are looking for. I appreciate the feedback here once again. I'm still fairly green but the more I'm catching these little mistakes, and the more i'm actually writing them out is helping a lot. I will be officially done with my regular job in a couple weeks, where I can devote my undivided attention to Turing and hopefully won't be making these mistakes in Java or minor misspellings going forward. I feel confident I made the correct changes you were asking for here, but please let me know. Thanks.
@Ish451
Nice work here- you are officially technical ready
! A few last pieces of feedback as you keep working:
When you see a class name in code, it will use a casing convention called PascalCase, and it will be singular. You will see this convention across different coding languages, so always try to use this for class names.
Very nice improvements to your variables file, and your method names! You caught everything I was looking for. Hopefully, it was a decent exercise in bug catching. One small suggestion- for method checkReservations
, if you are going to say it reassigns attribute reservations
to true
every time, you may think about using a word like add
or make
instead of check
.
Keep up the hard work! Let me know if you have questions.
@Ish451 You performed well enough on the assessment to merit a chance to make some changes that can promote you to
technical ready
. Please make the following updates by EOD Sunday:For each of your class files, you have 2 methods that do not begin with active words. Find these, and make some updates. One of them is deceptive-
drive
seems like an active word, but in this case, you refer to a drivethru, which is a noun. Here, you can just bring the third word to the front. The others will likely need added words to describe what you are doing. Overall, your methods that directly modify an attribute are more what we are looking for, rather than 'getter methods' likeavailableCapacity
that get some attributes and make a calculation.There were several detail errors in your variables file. I'm pointing them out here because attention to detail is something that can save a lot of syntax headaches as you begin coding. For instance, a misspelling like with
var isDelicios
versusvar isDelicious
could be the difference between if a program runs or not. For the quotient line, we were looking for the variables you declared on the prior 2 lines to be utilized, rather thanhard-coding
the answer of 3.5. Lastly, an actionable thing I'd like you to update- review your last 2 lines here: The code you have to remove the first item of the array doesn't really do that, it just delivers all the other items except the first item. There is a specific method that permanently takes the first item out of the array- see if you can find it doing some googling. Likewise, .split doesn't return a count of the length of that string, it returns an array. There is a specific method that returns the length of a string- see if you can find that one!Let me know if you have question, particularly about the research I've asked for about those methods. Also let me know if I can clarify anything.