search

IshaaanVyas / pe

0 stars 0 forks source link

Very complicated class diagrams #11

Open IshaaanVyas opened 2 years ago

IshaaanVyas commented 2 years ago

image.png

Could have made it much simpler and easier to understand by removing methods/attributes that were not necessary to the understanding of the class diagram. (Pretty sure all the print methods are not necessary to understand the relationship between the classes).

Here also this is very complicated:

image.png

nus-pe-bot commented 2 years ago

Team's Response

It is important to show all the methods of each class so that future developers can better understand our code.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Taken from website Week10 Project details: https://nus-cs2113-ay2122s1.github.io/website/schedule/week10/project.html

image.png

Since the team has failed to make the class diagram comprehensible, I feel this should be considered as a bug. I feel new developers would have large amounts of difficulty in understanding these diagrams.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]